Repository navigation
Fix exception handling in FT2Font init. - #17510
Merged
Merged
Conversation
QuLogic
added
Release critical
anntzer
reviewed
May 26, 2020
anntzer
reviewed
May 26, 2020
It needs to return -1 when an exception is set, or Python raises a `SystemError` instead.
anntzer
approved these changes
May 26, 2020
anntzer
left a comment
anntzer
left a comment
Contributor
There was a problem hiding this comment.
postci
thanks for cleaning up my mess :)
jklymak
approved these changes
Jun 1, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
It needs to return -1 when an exception is set, or Python raises a
SystemErrorinstead.Missed this in #15104.
PR Checklist