Repository navigation
Cleanup RectangleSelector example. - #17475
Merged
Merged
Conversation
timhoffm
approved these changes
May 21, 2020
timhoffm
left a comment
Member
There was a problem hiding this comment.
Um, when I toggle to deactivate and then toggle again to activate, I cannot control the existing rectangle, but a new one is drawn on top.
However, it doesn't seem your code is responsible. Likely some bug in rectangle selector (but cannot easily test as deactivating did not work in the original example due to duplicate key assignment. So I just approve the obvious improvement of you PR.
Contributor
Author
|
the bug is tracked at #17476. |
Member
|
The example in the class docstring for |
Member
|
Possibly, the example in the class docstring should be replaced by a link to this example. |
- Don't use "q" or "a" as keys given that they are already mapped to "quit" and "all_axes" (even though the latter is deprecated). - Document the interactivity directly as the axes title. - No need to plot too many things in the axes; they're irrelevant.
Contributor
Author
|
indeed, just made a link instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

"quit" and "all_axes" (even though the latter is deprecated).
PR Summary
PR Checklist