Skip to content

MEP30: make each "pseudotype" a class - #17446

Closed
brunobeltran wants to merge 1 commit into
matplotlib:mainfrom
brunobeltran:MEP30
Closed

brunobeltran wants to merge 1 commit into
matplotlib:mainfrom
brunobeltran:MEP30

Conversation

@brunobeltran

Copy link
Copy Markdown
Contributor

PR Summary

Hopefully I set this up correctly, looking forward to discussion!

@anntzer

anntzer commented May 19, 2020 •

Copy link
Copy Markdown
Contributor

In the specific case of capstyle and joinstyle, I think it should be relatively easy* to turn them into StrEnums (like IntEnums, but for strs...), i.e.

class CapStyle(str, Enum):
    butt = "butt"
    round = "round"
    projecting = "projecting"

and put the doc there together with whatever relevant methods, and just call it a day.

(*for mpl-specific values of "easy", conditions may apply)

@story645

story645 commented May 19, 2020 •

Copy link
Copy Markdown
Member

A discussed on the call, I like this ideas in terms of documentation/writing a matplotlib user manual of sorts...

I'm way more hesitant about it as code w/out a clear articulation of which parameters should be pseudotypes. But as a first pass, I think this intersects w/ #6738 since doing that properly would require a validation method per parameter.

@tacaswell tacaswell added this to the v3.4.0 milestone May 20, 2020
@QuLogic

QuLogic commented May 20, 2020

Copy link
Copy Markdown
Member

xref #14642 on enums.

Also, s/matplotlib/Matplotlib/g, mostly.

@QuLogic QuLogic modified the milestones: v3.4.0, v3.5.0 Jan 22, 2021
@jklymak
jklymak marked this pull request as draft May 8, 2021 22:42
@QuLogic QuLogic modified the milestones: v3.5.0, v3.6.0 Aug 23, 2021
@timhoffm timhoffm modified the milestones: v3.6.0, unassigned Apr 30, 2022
@story645 story645 modified the milestones: unassigned, needs sorting Oct 6, 2022
@github-actions

github-actions Bot commented Aug 2, 2023

Copy link
Copy Markdown

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions Bot added the status: inactive Marked by the “Stale” Github Action label Aug 2, 2023
@timhoffm

Copy link
Copy Markdown
Member

I propse to close this as too heavy. I think the solution is somewhere between StrEnums and Literal type annotations, c.f. #14642.

@github-actions github-actions Bot removed the status: inactive Marked by the “Stale” Github Action label Sep 13, 2023
@github-actions

Copy link
Copy Markdown

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions Bot added the status: inactive Marked by the “Stale” Github Action label Nov 13, 2023
@timhoffm timhoffm closed this Nov 13, 2023
@timhoffm timhoffm removed the status: inactive Marked by the “Stale” Github Action label Nov 13, 2023
@timhoffm timhoffm reopened this Nov 13, 2023
@timhoffm timhoffm closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants