Reuse inset_axes locator machinery for secondary_axes.#17249
Closed
anntzer wants to merge 1 commit into
Closed
Conversation
_make_secondary_locator is just a special-case of _make_inset_locator, so just use the latter. Also change _make_inset_locator to use transform subtraction instead of `.inverted()`, as it is typically more precise.
Member
|
Seems like an alternate to #14463? Better or worse? |
Contributor
Author
|
There's some overlap, but I think they can both go in? (I can rebase either way.) |
QuLogic
approved these changes
May 12, 2020
6 tasks
Member
|
#17993 replaces this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_make_secondary_locator is just a special-case of _make_inset_locator,
so just use the latter.
Also change _make_inset_locator to use transform subtraction instead of
.inverted(), as it is typically more precise (as discussed in #17206).PR Summary
PR Checklist