Repository navigation
Deprecate support for running svg converter from path containing newline. - #17211
Merged
Merged
Conversation
Contributor
Author
|
rebased |
QuLogic
approved these changes
Apr 28, 2020
tacaswell
approved these changes
Apr 28, 2020
Member
Contributor
Author
|
I guess I was just being extra extra careful; OTOH if glib's |
Inkscape's batch mode doesn't handle newlines(!) in file names, which tbh doesn't seem to be a too big restriction in practice. Right now we fallback on a specific path to handle that case, but I doubt that it is really hit, given that the batch ghostscript converter likely has the same limitation and no one complained about it for two years.
Member
|
The travis failure is the |
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inkscape's batch mode doesn't handle newlines(!) in file names, which
tbh doesn't seem to be a too big restriction in practice. Right now we
fallback on a specific path to handle that case, but I doubt that it is
really hit, given that the batch ghostscript converter likely has the
same limitation (since #9454) and no one complained about it for two years.
PR Summary
PR Checklist