Skip to content

ci: Publish result images as Azure artifacts.#17011

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
QuLogic:azure-artifacts
Apr 5, 2020
Merged

ci: Publish result images as Azure artifacts.#17011
tacaswell merged 1 commit into
matplotlib:masterfrom
QuLogic:azure-artifacts

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 2, 2020

Copy link
Copy Markdown
Member

This should allow us to debug result images if they're failing on Azure.

@QuLogic

QuLogic commented Apr 3, 2020

Copy link
Copy Markdown
Member Author

I'm thinking we probably want to add a condition so publishing works when stuff fails, but I didn't add it here just to see what the results look like. Should we publish always or only on failure?

@anntzer

anntzer commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

I guess only-on-failure is good enough for now?

@QuLogic

QuLogic commented Apr 3, 2020

Copy link
Copy Markdown
Member Author

Hmm, looks like I need to give it a stage-specific name.

@QuLogic

QuLogic commented Apr 3, 2020

Copy link
Copy Markdown
Member Author

So Windows Prerelease build failed because nothing was actually run. Seems we're a bit too relaxed with that one.

@QuLogic

QuLogic commented Apr 3, 2020

Copy link
Copy Markdown
Member Author

I added the on-failure condition, and skipped artifacts for the Prerelease build (which is broken right now). You can see what it looks like in the previous build. In the top card, under the Related heading, there is the "9 published" link which points to the artifacts. If you're on a specific Job view, then there's a link to "1 artifact produced".

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@tacaswell tacaswell merged commit 285e987 into matplotlib:master Apr 5, 2020
@tacaswell tacaswell added this to the v3.3.0 milestone Apr 5, 2020
@QuLogic QuLogic deleted the azure-artifacts branch April 6, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants