Skip to content

Conversation

@meeseeksmachine
Copy link
Contributor

Backport PR #16770: Fix tuple markers

@QuLogic
Copy link
Member

QuLogic commented Mar 16, 2020

To get this to work, it looks like we should either increase the tolerance on test_asterisk_marker and drop the stuff that checks request, or backport #15199.

@tacaswell
Copy link
Member

I vote backport, it is testing details, not user-facing so it is OK.

xref #16795

@QuLogic QuLogic closed this Mar 16, 2020
@QuLogic QuLogic reopened this Mar 16, 2020
@QuLogic QuLogic merged commit e935d85 into matplotlib:v3.2.x Mar 17, 2020
@Erotemic
Copy link

Thanks for this fix! Broken marker tuples are currently impacting my packages, is there a timeline when 3.2.1 will be on pypi? In the meantime I guess I'll pin my versions to 3.1.2

@QuLogic
Copy link
Member

QuLogic commented Mar 17, 2020

Well, it's good to see someone uses it, and fixing it by chance was useful. Please consider adding Framework :: Matplotlib to your PyPI classifiers on kwplot.

3.2.1 is planned for tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants