Skip to content

Fix exception causes all over the codebase #16706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tacaswell merged 1 commit into from
Mar 9, 2020
Merged

Fix exception causes all over the codebase #16706

tacaswell merged 1 commit into from
Mar 9, 2020

Conversation

@cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Mar 7, 2020 •
edited
Loading

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@cool-RR cool-RR force-pushed the 2020-03-07-raise-from branch from 0fc9899 to 40d7449 Compare March 7, 2020 18:41
@cool-RR
Copy link
Contributor Author

cool-RR commented Mar 8, 2020

@timhoffm Ready for review

@jklymak
Copy link
Member

jklymak commented Mar 9, 2020

Maybe you could include a few words as to why we want to use this grammar?

@jklymak jklymak requested a review from timhoffm March 9, 2020 16:49
@cool-RR
Copy link
Contributor Author

cool-RR commented Mar 9, 2020

@jklymak This is the final part of #16684.

Basically this makes the right message appear between the two tracebacks.

jklymak
jklymak approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look fine to me. Would be nice if the test coverage was better, but don't expect you to write a bunch of tests that trigger exceptions...

@tacaswell tacaswell merged commit 266d797 into matplotlib:master Mar 9, 2020
@tacaswell
Copy link
Member

tacaswell commented Mar 9, 2020

Thanks @cool-RR !

This was referenced Mar 9, 2020
Closed
Closed
Closed
@QuLogic QuLogic added this to the v3.3.0 milestone Mar 10, 2020
This was referenced Jun 9, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
This was referenced Jun 12, 2020
Open
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Open
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 24, 2020

I just made a blog post about this change here: https://blog.ram.rachum.com/post/621791438475296768/improving-python-exception-chaining-with

@cool-RR cool-RR mentioned this pull request Feb 20, 2021
Merged
@cool-RR cool-RR mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm Awaiting requested review from timhoffm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cool-RR @jklymak @tacaswell @QuLogic