Allow MarkerStyle instances as input for lines #16692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportanceOfBeingErnest
force-pushed
the
marker-for-lines
branch
from
a12d32b to
dbfd024
Compare
tacaswell
approved these changes
Mar 6, 2020
Member
tacaswell
left a comment
tacaswell
left a comment
There was a problem hiding this comment.
This should get a whats_new entry ?
pharshalp
reviewed
Mar 6, 2020
ImportanceOfBeingErnest
force-pushed
the
marker-for-lines
branch
2 times, most recently
from
c6840ef to
4b69a29
Compare
QuLogic
reviewed
Mar 12, 2020
lib/matplotlib/tests/test_lines.py
Outdated
| fig.canvas.draw() | ||
| assert line.get_marker() == "D" | ||
|
|
||
| #continue with smoke tests: |
Member
There was a problem hiding this comment.
There should be a space after #; dunno why flake8 isn't complaining.
Member
Author
There was a problem hiding this comment.
This is because E265 is ignored throughout:
Line 8 in 2f85640
ImportanceOfBeingErnest
force-pushed
the
marker-for-lines
branch
from
4b69a29 to
ac8c2bf
Compare
QuLogic
approved these changes
Mar 12, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
scatterallows to pass aMarkerStyleinstances asmarker.plotdid not allow for that up to now.This PR fixes this, such that
will work as expected.
This is leveraged by allowing
MarkerStyleto take an instance of itself as input.PR Checklist