Skip to content

Fix exception causes in 19 modules #16684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anntzer merged 1 commit into from
Mar 6, 2020
Merged

Fix exception causes in 19 modules #16684

anntzer merged 1 commit into from
Mar 6, 2020

Conversation

@cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Mar 5, 2020 •
edited
Loading

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

WeatherGod
WeatherGod reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this has been a long-needed change. I will point out that you will likely see style-checker failures due to the use of single letter e variable. I would prefer if we kept with the convention of err instead.

@cool-RR cool-RR force-pushed the 2020-03-05-raise-from branch from 1fec42d to da70ca2 Compare March 5, 2020 17:42
@cool-RR
Copy link
Contributor Author

cool-RR commented Mar 5, 2020

Renamed to err

@tacaswell
Copy link
Member

tacaswell commented Mar 5, 2020

I looks like this pushed a bunch of lines over the length limit

77.05s$ if [[ $RUN_FLAKE8 == 1 ]]; then
2389  flake8 --statistics && echo "Flake8 passed without any issues!"
2390fi
2391
2392./lib/matplotlib/offsetbox.py:1171:80: E501 line too long (87 > 79 characters)
2393./lib/matplotlib/patches.py:1854:80: E501 line too long (82 > 79 characters)
2394./lib/matplotlib/table.py:362:80: E501 line too long (87 > 79 characters)
2395./lib/matplotlib/mathtext.py:2726:80: E501 line too long (80 > 79 characters)
2396./lib/matplotlib/ticker.py:2853:80: E501 line too long (86 > 79 characters)
2397./lib/matplotlib/streamplot.py:376:80: E501 line too long (85 > 79 characters)
2398./lib/matplotlib/testing/decorators.py:198:80: E501 line too long (84 > 79 characters)
2399./lib/matplotlib/testing/compare.py:185:80: E501 line too long (86 > 79 characters)
24008     E501 line too long (80 > 79 characters)

Over all 👍

tacaswell
tacaswell approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the flake8 issues getting resolved.

@tacaswell tacaswell added this to the v3.3.0 milestone Mar 5, 2020
@tacaswell
Copy link
Member

tacaswell commented Mar 5, 2020

Thanks @cool-RR !

@cool-RR cool-RR force-pushed the 2020-03-05-raise-from branch from da70ca2 to c89ac3e Compare March 6, 2020 11:16
@cool-RR cool-RR marked this pull request as ready for review March 6, 2020 13:34
@anntzer anntzer merged commit 376b75d into matplotlib:master Mar 6, 2020
@cool-RR cool-RR mentioned this pull request Mar 9, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WeatherGod WeatherGod WeatherGod left review comments

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cool-RR @tacaswell @WeatherGod @timhoffm @anntzer