Repository navigation
Don't default to negative radii in polar plot. - #16300
Merged
Merged
Conversation
Previously a call to `polar()` (with no args) would default the rlims to -0.05, +0.05 (unlike `subplot(projection="polar")` which would default the rlims to a more sane (0, 1)). Fix that.
dstansby
approved these changes
Jan 23, 2020
dstansby
left a comment
dstansby
left a comment
Member
There was a problem hiding this comment.
Should probably get a what's new entry?
Contributor
Author
|
I think this is closer to a bugfix (back to pre 2.0 behavior). Also if this can make it to 3.2 I guess https://github.com/matplotlib/matplotlib/pull/13980/files#diff-96669b74374a21dbde3b7c470522eebfR23 mostly covers that (even though the internals are different). Actually let's milestone this to 3.2... |
jklymak
approved these changes
Jan 23, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 23, 2020
timhoffm
added a commit
that referenced
this pull request
Jan 23, 2020
…300-on-v3.2.x Backport PR #16300 on branch v3.2.x (Don't default to negative radii in polar plot.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a call to
polar()(with no args) would default the rlims to-0.05, +0.05 (unlike
subplot(projection="polar")which would defaultthe rlims to a more sane (0, 1)). Fix that.
I guess this would be nice for 3.2, but won't insist on it, feel free to milestone as preferred.
PR Summary
PR Checklist