Skip to content

STY: Fix underindented continuation lines. - #16279

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:e128
Feb 25, 2020
Merged

tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:e128

Conversation

@anntzer

@anntzer anntzer commented Jan 21, 2020 •

Copy link
Copy Markdown
Contributor

I don't agree with all indent choices of pycodestyle but these look
mostly like improvements.

Not doing the corresponding fix for overindented lines because I think PyCQA/pycodestyle#569 needs to be fixed first.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Jan 21, 2020
# need to change the orientation.
self._locstrings = self._locstrings[::-1]
elif align != self._locstrings[0]:
raise ValueError('"{}" is not a valid axis orientation, '

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic here was incorrect (we already checked that align in self._locstrings).

@anntzer
anntzer force-pushed the e128 branch 2 times, most recently from dfee54c to 4f5cfdb Compare January 24, 2020 08:19
Comment thread lib/matplotlib/colorbar.py Resolved
Comment thread tools/boilerplate.py Resolved
Comment thread lib/matplotlib/tests/test_quiver.py Resolved
Comment thread lib/matplotlib/_layoutbox.py Resolved
@anntzer
anntzer force-pushed the e128 branch 2 times, most recently from 14bc3ee to ab61a38 Compare January 26, 2020 12:10
Comment thread tools/boilerplate.py Resolved
@anntzer

anntzer commented Feb 22, 2020

Copy link
Copy Markdown
Contributor Author

rebased

I don't agree with *all* indent choices of pycodestyle but these look
mostly like improvements.
@tacaswell
tacaswell merged commit 9895288 into matplotlib:master Feb 25, 2020
@anntzer
anntzer deleted the e128 branch February 25, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants