Skip to content

Fix deprecation from #13544#16212

Merged
NelleV merged 1 commit into
matplotlib:masterfrom
timhoffm:fix-deprecation
Jan 14, 2020
Merged

Fix deprecation from #13544#16212
NelleV merged 1 commit into
matplotlib:masterfrom
timhoffm:fix-deprecation

Conversation

@timhoffm

Copy link
Copy Markdown
Member

PR Summary

From #13544 (comment)

@timhoffm timhoffm added status: confirmed bug Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Jan 13, 2020
@timhoffm timhoffm added this to the v3.2.0 milestone Jan 13, 2020

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops.

@NelleV

NelleV commented Jan 14, 2020

Copy link
Copy Markdown
Member

Thanks @timhoffm
In general, when bugs are detected, a unit test should be added. It is surprisingly not in our reviewer/contributing guidelines, but we have in the past reintroduced bugs by not consistently writing unit tests.

@timhoffm timhoffm deleted the fix-deprecation branch January 14, 2020 19:33
@timhoffm

Copy link
Copy Markdown
Member Author

@NelleV In general I agree, but we almost certainly won't touch this deprecated code anymore before removing. So I don't think it's worth the effort adding a test now.

timhoffm added a commit that referenced this pull request Jan 14, 2020
…212-on-v3.2.x

Backport PR #16212 on branch v3.2.x (Fix deprecation from #13544)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. status: confirmed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants