Skip to content

Expire deprecation of \stackrel#16206

Merged
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:unstackrel
Feb 8, 2020
Merged

Expire deprecation of \stackrel#16206
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:unstackrel

Conversation

@anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 13, 2020

PR Summary

Like #16204, but for \stackrel.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Jan 13, 2020
@anntzer anntzer mentioned this pull request Jan 13, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #16206 into master will decrease coverage by 6.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16206      +/-   ##
==========================================
- Coverage   80.87%   74.85%   -6.02%     
==========================================
  Files         306      275      -31     
  Lines       75758    68664    -7094     
  Branches     9690     9686       -4     
==========================================
- Hits        61268    51401    -9867     
- Misses      11953    14907    +2954     
+ Partials     2537     2356     -181
Impacted Files Coverage Δ
lib/matplotlib/backends/backend_gtk3cairo.py 0.00% <0.00%> (-100.00%) ⬇️
...b/matplotlib/backends/qt_editor/formsubplottool.py 0.00% <0.00%> (-100.00%) ⬇️
lib/matplotlib/backends/backend_qt5cairo.py 0.00% <0.00%> (-89.19%) ⬇️
lib/matplotlib/backends/backend_qt4agg.py 20.00% <0.00%> (-80.00%) ⬇️
lib/matplotlib/tests/test_backend_qt.py 14.75% <0.00%> (-78.38%) ⬇️
lib/matplotlib/tests/test_backend_cairo.py 25.00% <0.00%> (-75.00%) ⬇️
lib/matplotlib/tests/test_usetex.py 30.55% <0.00%> (-69.45%) ⬇️
lib/matplotlib/backends/backend_wxcairo.py 0.00% <0.00%> (-64.00%) ⬇️
lib/matplotlib/backends/backend_qt5agg.py 10.63% <0.00%> (-63.83%) ⬇️
lib/matplotlib/backends/backend_pgf.py 19.08% <0.00%> (-61.03%) ⬇️
... and 198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c449ee4...de733cb. Read the comment docs.

tacaswell
tacaswell reviewed Feb 7, 2020
View reviewed changes
lib/matplotlib/tests/test_mathtext.py
@@ -93,7 +93,6 @@
r'$\operatorname{cos} x$', # github issue #553
r'$\sum _{\genfrac{}{}{0}{}{0\leq i\leq m}{0<j<n}}P\left(i,j\right)$',
r"$\left\Vert a \right\Vert \left\vert b \right\vert \left| a \right| \left\| b\right\| \Vert a \Vert \vert b \vert$",
r'$\mathring{A} \stackrel{\circ}{A} \AA$',
Copy link
Member

@tacaswell tacaswell Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave in the test as r'$\mathring{A} \AA$', ? I don't think we other wise have coverage of those symbols and it will avoid the re-numbering of the tests which is very confusing.

If we really want to drop this test, we should leave a None in place and filter it a bit farther down just before we feed paramaterize.

tacaswell
tacaswell requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have an idea on how to avoid re-numbering everything

tacaswell
tacaswell approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only modify the test.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 8, 2020 •
edited
Loading

Your patch looks fine to me.

@tacaswell tacaswell merged commit 85fd1ab into matplotlib:master Feb 8, 2020
@anntzer anntzer deleted the unstackrel branch February 8, 2020 17:17
@tacaswell tacaswell mentioned this pull request Feb 8, 2020
Merged
@anntzer anntzer mentioned this pull request Feb 8, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

API: changes Maintenance topic: text/mathtext

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @tacaswell @timhoffm