Skip to content

Using a stricter check to see if Python was installed as a framework.#1613

Merged
efiring merged 1 commit into
matplotlib:masterfrom
mdehoon:fix-for-framework-check
Jan 10, 2013
Merged

Using a stricter check to see if Python was installed as a framework.#1613
efiring merged 1 commit into
matplotlib:masterfrom
mdehoon:fix-for-framework-check

Conversation

@mdehoon

@mdehoon mdehoon commented Dec 20, 2012

Copy link
Copy Markdown
Contributor

Using a stricter check to see if Python was installed as a framework. Also, because of the recurring problems with non-framework Pythons, importing the Mac OS X backend will now fail (instead of just issuing a warning) if Python is not installed as a framework. This patch uses the WITH_NEXT_FRAMEWORK macro in pyconfig.h to determine if Python is installed as a framework. This is safer than the previous approach using CGMainDisplayID().

This is a bug fix for issue 665 (#665).

… Also, because of the recurring problems with non-framework Pythons, importing the Mac OS X backend will now fail (instead of just issuing a warning) if Python is not installed as a framework.
@asmeurer

Copy link
Copy Markdown
Contributor

I can confirm that this works as expected.

@asmeurer

Copy link
Copy Markdown
Contributor

I also checked in Python 3 non-framework (I didn't check Python 3 framework because I don't have numpy installed there and I didn't want to do it).

@mdehoon

mdehoon commented Dec 20, 2012

Copy link
Copy Markdown
Contributor Author

Thanks. I have checked with Python 3 framework; it works as expected.

efiring added a commit that referenced this pull request Jan 10, 2013
Using a stricter check to see if Python was installed as a framework.
@efiring efiring merged commit 9f74de0 into matplotlib:master Jan 10, 2013
@anntzer anntzer mentioned this pull request Aug 13, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants