Repository navigation
Code style cleanup - #16044
Merged
Merged
Code style cleanup#16044
Conversation
timhoffm
commented
Dec 30, 2019
| def v_interval(self): | ||
| return self.get_view_interval() | ||
|
|
||
| @d_interval.setter |
Member
Author
There was a problem hiding this comment.
This was actually a bug.
Contributor
There was a problem hiding this comment.
Would love to have a test for this...
Contributor
There was a problem hiding this comment.
We should actually just deprecate them, as they are just mplot3d-specific synonyms for {get,set}_{view,data}_interval...
timhoffm
force-pushed
the
codestyle-cleanup
branch
from
December 30, 2019 14:03
e7e490e to
46949af
Compare
jklymak
approved these changes
Dec 30, 2019
anntzer
reviewed
Dec 30, 2019
anntzer
reviewed
Dec 30, 2019
anntzer
reviewed
Dec 30, 2019
timhoffm
force-pushed
the
codestyle-cleanup
branch
from
December 31, 2019 10:40
46949af to
fca65ed
Compare
Merged
anntzer
approved these changes
Dec 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
if myvar:instead ofif myvar != []: