Trying to set the labels without setting ticks through pyplot now raises TypeError*#15927
Merged
anntzer merged 1 commit intoDec 16, 2019
Conversation
timhoffm
reviewed
Dec 13, 2019
rscmendes
force-pushed
the
throw-error-on-empty-ticks-for-issue-15005
branch
from
d963707 to
274fbdc
Compare
rscmendes
changed the title
timhoffm
added
API: changes
timhoffm
reviewed
Dec 15, 2019
rscmendes
force-pushed
the
throw-error-on-empty-ticks-for-issue-15005
branch
from
274fbdc to
a9ebd40
Compare
Author
|
Sorry for the flask8 compliance issue, thought it was OK with 80 but should've tested -- still have a lot to learn. Should be good now. |
timhoffm
approved these changes
Dec 15, 2019
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
Thanks! From my side, this is good to go. Waiting for a second positive review.
Commits should still be squashed. Can be done by the author locally + force-push; or if you're not that familiar with git, we'll squash through the github interface when merging.
anntzer
reviewed
Dec 15, 2019
…ses TypeError with a proper message
rscmendes
force-pushed
the
throw-error-on-empty-ticks-for-issue-15005
branch
from
a9ebd40 to
86dd139
Compare
Contributor
|
Thanks for the PR, hoping to see you around again :) |
anntzer
approved these changes
Dec 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR was suggested in issue #15005 as to fix the error that is returned when xticks() or yticks() is called with only the labels as parameters. It is also a follow up from PR #15788.
Previously, passing labels without passing the ticks to either
pyplot.xticks()andpyplot.yticks()would result inTypeError: object of type 'NoneType' has no len(). With this PR it now returns:AttributeError: Labels can't be set without setting ticks.PS: apologies for the delay.
PR Checklist