CI: use python -m to make sure we are using the pip/pytest we want#15300
Closed
tacaswell wants to merge 1 commit intomatplotlib:masterfrom
Closed
CI: use python -m to make sure we are using the pip/pytest we want#15300tacaswell wants to merge 1 commit intomatplotlib:masterfrom
tacaswell wants to merge 1 commit intomatplotlib:masterfrom
Conversation
timhoffm
approved these changes
Sep 19, 2019
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Looks good, conditional on CI pass.
Member
|
Indeed ti does fail as per #15295. Confused about what we want to do about that? Do you want this merged with the breaking build? |
jklymak
approved these changes
Sep 25, 2019
Member
Author
|
We should re-run the test when 3.8rc1 comes out (should be in a week or two). [edited to fix typo in version] |
Contributor
(mumbles snarky comment about how Guido finally gave in and decided to do a 2.8 release after all ;)) |
Member
Author
|
power-cycled to restart CI now that 3.8.0rc1 is available. |
Member
Author
|
It looks like we are still failing on the python pre-release, but in a different way when compiling numpy.... |
Member
Author
|
Closing in favor of #15418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow up to work in #15168 that discovered we were not actually using the envs we thought we were (as we were not seeing the warnings on 3.8).
Expect this to fail on the 3.8.0b4 for the same reason as #15295