Repository navigation
Composite against white, not the savefig.facecolor rc, in print_jpeg. - #15239
Merged
Merged
Conversation
jpeg doesn't support alpha transparency, so we need to paste the image
against some solid background before saving it. Pasting against the
savefig.facecolor rc, as the code did before, is just wrong: it makes
e.g.
```
plot([1, 2])
rcParams["savefig.facecolor"] = "blue"
savefig("/tmp/foo.jpg", facecolor=(1, 0, 0, .5))
```
result in a purple background (blue + 0.5 red), instead of a red one (as
for png -- the facecolor kwarg should just override the rcParam).
Likewise the test_jpeg_alpha test was just wrong (indeed, trying to run
the same code but saving as png shows that transparent=True should
override the savefig.facecolor rcParam).
Instead, paste the image against a white background, which fixes the
issues (and is tested by the fixed test_jpeg_alpha).
dstansby
approved these changes
Sep 10, 2019
timhoffm
approved these changes
Sep 11, 2019
Member
|
Does this need a change note? |
Contributor
Author
|
It's more like an obscure bugfix, I guess, and no one ever reported this so I wouldn't bother :p |
Member
|
AFAICS this only happens when
That's probably a very rare combination. So, I'm fine without a note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jpeg doesn't support alpha transparency, so we need to paste the image
against some solid background before saving it. Pasting against the
savefig.facecolor rc, as the code did before, is just wrong: it makes
e.g.
result in a purple background (blue + 0.5 red), instead of a red one (as
for png -- the facecolor kwarg should just override the rcParam).
Likewise the test_jpeg_alpha test was just wrong (indeed, trying to run
the same code but saving as png shows that transparent=True should
override the savefig.facecolor rcParam).
Instead, paste the image against a white background, which fixes the
issues (and is tested by the fixed test_jpeg_alpha).
PR Summary
PR Checklist