-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
By default, don't change the figure face/edgecolor on savefig(). #15111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ec90642 to
cec9ed4
Compare
|
The In general this makes much more sense to me than #10023. I don't understand the exitstack thingy so I will leave this for others to review. |
|
For colors, there's already places that accept "auto" and places that accept "inherit" (specifically, legends). I'd rather not add a third spelling for the same (general) idea. (In fact I plan to deprecate "inherit" in favor of "auto", but that's a separate issue.) |
cec9ed4 to
7f9dea1
Compare
|
|
7f9dea1 to
4e36c54
Compare
|
So what do you think the "auto" cases of lines.markerfacecolor, lines.markeredgecolor, boxplot.flierprops.markerfacecolor, and axes.titlecolor should be named? |
4e36c54 to
bfc7093
Compare
bfc7093 to
12a81c7
Compare
12a81c7 to
1552f80
Compare
This seems to repeatedly confuse users.
efiring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea: a move towards the goal of minimizing surprise.
|
I see your your point @ImportanceOfBeingErnest , however I think that the ambiguity of "auto" is a benefit here because we can use the same spelling across a wide range of contexts. |
This seems to repeatedly confuse users.
Closes #7619; fixes https://gitter.im/matplotlib/matplotlib?at=5d5faff768406739f96b2673; alternate for #10023.
PR Summary
PR Checklist