Skip to content

Use warnings.warn, not logging.warning, in microseconds locator warning. - #15000

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:microwarn
Aug 7, 2019
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:microwarn

Conversation

@anntzer

@anntzer anntzer commented Aug 7, 2019

Copy link
Copy Markdown
Contributor

Otherwise something like

from pylab import *
from matplotlib import dates; from datetime import *
plt.plot([datetime(1990, 1, 1), datetime(1990, 1, 1) + timedelta(microseconds=1500)], [0, 0])
plt.show()

results in the same warning being emitted multiple times for every
draw
(e.g. when zooming/panning), which is pretty needless spam.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm timhoffm added this to the v3.2.0 milestone Aug 7, 2019
Otherwise something like
```
from pylab import *
from matplotlib import dates; from datetime import *
plt.plot([datetime(1990, 1, 1), datetime(1990, 1, 1) + timedelta(microseconds=1500)], [0, 0])
plt.show()
```
results in the same warning being emitted multiple times *for every
draw* (e.g. when zooming/panning), which is pretty needless spam.
@anntzer

anntzer commented Aug 7, 2019

Copy link
Copy Markdown
Contributor Author

rebased

@timhoffm
timhoffm merged commit a8d2738 into matplotlib:master Aug 7, 2019
@anntzer
anntzer deleted the microwarn branch August 7, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants