Changes icon when using macosx backend #14927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not completely sure of the idioms used in this codebase, but I generally prefer avoiding goto and passing NULL into 3rd-party functions. Also not sure whether conventions are to keep things in C/Objective-C or to put them in Python. Also, used PDF instead of png, as MacOS supports vector icons. (Nice!) Comments/requests welcome. |
2 tasks
QuLogic
reviewed
Jul 31, 2019
joelfrederico
force-pushed
the
macos-icon
branch
from
c8e532c to
16e2d2f
Compare
Contributor
Author
|
Closing in favor of #14930. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sets the icon to the matplotlib icon when using the macos backend. (See #14850.)
PR Checklist
(No items are applicable.)