Repository navigation
Don't redownload jquery when installing from an sdist - #14915
Conversation
|
Thanks @AWhetter ! |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
BLD: Don't redownload jquery when installing from an sdist
BLD: Don't redownload jquery when installing from an sdist
|
The conflicts on both branches were with import order so fortunately super easy to resolve! |
BLD: Don't redownload jquery when installing from an sdist
BLD: Don't redownload jquery when installing from an sdist
…-v3.1.x BLD: use jquery in sdist when installing from sdist Merge pull request #14915 from AWhetter/fix_14585
…-v2.2.x BLD: use jquery in sdist when installing from sdist Merge pull request #14915 from AWhetter/fix_14585
Closes #14585
PR Summary
The source for jquery-ui is already made available as part of the sdist. This change avoids downloading jquery-ui at all if installing from the sdist and jquery-ui can be found locally.
The use case I have is we don't have access to the internet. We access matplotlib through a devpi mirror. Unfortunately our build system requires us to install from an sdist rather than a wheel.
Ideally this would be backported to the v2.2.x branch. Should I submit a separate pull request for that?
PR Checklist