Repository navigation
Don't use pandas 0.25.0 for testing - #14861
Merged
Merged
Conversation
Member
|
Yeah if we think we can fix in pandas. |
Member
|
appveyor still fails
|
dstansby
force-pushed
the
pandas-badversion
branch
from
July 20, 2019 17:22
c9b2aa6 to
5ad791e
Compare
timhoffm
approved these changes
Jul 21, 2019
jklymak
approved these changes
Jul 21, 2019
Member
Author
|
@meeseeksdev backport to v3.1.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
dstansby
added a commit
that referenced
this pull request
Jul 21, 2019
Member
|
Backported in dec7c67 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @bingyao for putting in a quick fix here: #14860; I think blacklisting pandas 0.25.0 is the correct long term thing to do however, as a fix (pandas-dev/pandas#27481) should hopefully go into 0.25.1