Skip to content

Factor out retrieval of data relative to datapath - #14104

Merged
efiring merged 1 commit into
matplotlib:masterfrom
anntzer:data_path
May 23, 2019
Merged

efiring merged 1 commit into
matplotlib:masterfrom
anntzer:data_path

Conversation

@anntzer

@anntzer anntzer commented Apr 30, 2019

Copy link
Copy Markdown
Contributor

... into a cbook._get_data_path() helper.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@efiring efiring left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, and then let's merge it.

@anntzer

anntzer commented May 22, 2019

Copy link
Copy Markdown
Contributor Author

done

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

... into a cbook._get_data_path() helper.
@efiring
efiring merged commit 9814fe8 into matplotlib:master May 23, 2019
@anntzer
anntzer deleted the data_path branch May 23, 2019 05:04
@QuLogic QuLogic added this to the v3.2.0 milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants