Skip to content

Fix colorbar setting without artist - #13966

Merged
anntzer merged 2 commits into
matplotlib:masterfrom
dstansby:custom-cbar
Apr 17, 2019
Merged

anntzer merged 2 commits into
matplotlib:masterfrom
dstansby:custom-cbar

Conversation

@dstansby

Copy link
Copy Markdown
Member

Fixes #13963

@jklymak

jklymak commented Apr 15, 2019

Copy link
Copy Markdown
Member

I dunno, I think if all the mappables tested in the test suite had a get_alpha method, then the base ScalarMappable method should have a get_alpha method

Comment thread lib/matplotlib/cm.py Resolved

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can merge after #13966 (review) is handled.

@dstansby dstansby added this to the v3.1.0 milestone Apr 17, 2019
@anntzer
anntzer merged commit 366a5d1 into matplotlib:master Apr 17, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 17, 2019
tacaswell added a commit that referenced this pull request Apr 17, 2019
…966-on-v3.1.x

Backport PR #13966 on branch v3.1.x (Fix colorbar setting without artist)
@dstansby
dstansby deleted the custom-cbar branch April 17, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataless colorbars break when updated

4 participants