Correctly handle fallout of defining PY_SSIZE_T_CLEAN on Windows.#13868
Merged
Conversation
dstansby
approved these changes
Apr 3, 2019
jklymak
approved these changes
Apr 3, 2019
jklymak
left a comment
jklymak
left a comment
Member
There was a problem hiding this comment.
This seems to have made all the tests happy.
Member
|
Be good if @tacaswell had a quick look and merged since he made the original change... |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 3, 2019
![MeeseeksDev[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…_SSIZE_T_CLEAN on Windows.
Member
|
Thanks for sorting this out @anntzer. |
dstansby
added a commit
that referenced
this pull request
Apr 3, 2019
…868-on-v3.1.x Backport PR #13868 on branch v3.1.x (Correctly handle fallout of defining PY_SSIZE_T_CLEAN on Windows.)
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 19, 2019
FIX: Correctly handle fallout of defining PY_SSIZE_T_CLEAN on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Perhaps fixes #13865, given the note at https://docs.python.org/3/c-api/arg.html#strings-and-buffers.
PR Checklist