Repository navigation
Ensure figsize is positive finite - #13859
Merged
Merged
Conversation
anntzer
approved these changes
Apr 3, 2019
WeatherGod
previously requested changes
Apr 3, 2019
WeatherGod
left a comment
WeatherGod
left a comment
Member
There was a problem hiding this comment.
Just a style fix. Otherwise, looks good.
| fig.set_size_inches(1, np.nan) | ||
| fig.set_size_inches(width, height) | ||
|
|
||
| def test_invalid_figure_add_axes(): |
Member
There was a problem hiding this comment.
Need two blank lines here, which is what travis is failing on.
timhoffm
force-pushed
the
positive-figsize
branch
from
April 4, 2019 00:20
1b188f2 to
1453d52
Compare
timhoffm
force-pushed
the
positive-figsize
branch
from
April 4, 2019 00:25
1453d52 to
da83457
Compare
dstansby
approved these changes
Apr 4, 2019
Member
Author
|
This is ready to merge. |
6 tasks
Contributor
|
Thanks! |
davidgegiya
added a commit
to davidgegiya/agent-orchestrator
that referenced
this pull request
Nov 9, 2026
Pin acad890afb1da7d071049d44ec655e0ae5b79e53 and its regression selectors for reproducible runs. Source: matplotlib/matplotlib#13859
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #13857. We were only checking for finite figsize. Changed that to positive finite.
PR Checklist