Skip to content

Fix failure to import matplotlib.animation on Windows. - #13787

Merged
dstansby merged 1 commit into
matplotlib:masterfrom
anntzer:animwin
Mar 29, 2019
Merged

dstansby merged 1 commit into
matplotlib:masterfrom
anntzer:animwin

Conversation

@anntzer

@anntzer anntzer commented Mar 28, 2019

Copy link
Copy Markdown
Contributor

Path objects can't be passed to subprocess.Popen on Windows.

closes #13786.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Path objects can't be passed to subprocess.Popen on Windows.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: animation labels Mar 28, 2019
@anntzer anntzer added this to the v3.1.0 milestone Mar 28, 2019

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure looks like either installation issues or more API changes in sphinx....

@dstansby
dstansby merged commit 7e9c756 into matplotlib:master Mar 29, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 29, 2019
@anntzer
anntzer deleted the animwin branch March 29, 2019 10:52
dstansby added a commit that referenced this pull request Mar 29, 2019
…787-on-v3.1.x

Backport PR #13787 on branch v3.1.x (Fix failure to import matplotlib.animation on Windows.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: animation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot import matplotlib.animation

3 participants