Fix stem(use_line_collection) #13745
Merged
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
timhoffm
added
the
Release critical
Member
Author
|
Marking as release critical, because |
Member
|
Do we know how this broke? |
jklymak
approved these changes
Mar 23, 2019
Member
Author
|
I think this was an oversight in the original implementation and never worked with |
Member
|
I suppose it could use a test in that case 😉 |
timhoffm
force-pushed
the
fix-stem-linestyle
branch
from
8bf4e02 to
9381302
Compare
Member
Author
|
Test added. |
lib/matplotlib/axes/_axes.py
Outdated
| stemlines = [] | ||
| stemlines = [((xi, bottom), (xi, yi)) for xi, yi in zip(x, y)] | ||
| if linestyle is None: | ||
| linestyle = 'solid' |
There was a problem hiding this comment.
Should this maybe rather evaluate the lines.linestyle rc parameter?
timhoffm
force-pushed
the
fix-stem-linestyle
branch
from
9381302 to
013dfc1
Compare
6 tasks
ImportanceOfBeingErnest
approved these changes
Mar 24, 2019
QuLogic
approved these changes
Mar 24, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 24, 2019
timhoffm
added a commit
that referenced
this pull request
Mar 24, 2019
…745-on-v3.1.x Backport PR #13745 on branch v3.1.x (Fix stem(use_line_collection))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fails because
linefmtis resolved tolinestyle = None, which is not a valid parameter value forLineCollection.The fix is consistent with the behavior of
use_line_collection=False.