Repository navigation
FIX: make title move above ticklabels - #13741
Merged
Merged
Conversation
jklymak
marked this pull request as ready for review
March 23, 2019 04:36
Member
Author
|
The doc build has been flakey lately - I don't think this has anything to do w/ this PR... |
Member
|
Not sure, what's failing the doc build. The only thing I've found in the log is #13743. But that's been around for some time. |
timhoffm
reviewed
Mar 23, 2019
jklymak
force-pushed
the
fix-move-title-ticklabels
branch
from
March 23, 2019 14:49
851967f to
b3b3659
Compare
timhoffm
approved these changes
Mar 24, 2019
jklymak
force-pushed
the
fix-move-title-ticklabels
branch
from
March 24, 2019 15:32
b3b3659 to
6f0b9a0
Compare
jklymak
force-pushed
the
fix-move-title-ticklabels
branch
from
March 25, 2019 03:54
6f0b9a0 to
b4a1a97
Compare
Member
Author
|
This is a pretty small fix that would be nice to get in for 3.1 if anyone els had a minute to check it. |
ImportanceOfBeingErnest
approved these changes
Mar 25, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 25, 2019
jklymak
added a commit
that referenced
this pull request
Mar 25, 2019
…741-on-v3.1.x Backport PR #13741 on branch v3.1.x (FIX: make title move above ticklabels)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Titles are supposed to avoid tick labels as of #9498. However, if ticks are labeled at the top and bottom of a plot,
ax.xaxis.get_ticks_position()returns "unknown" instead of "top", so old logic didn't move title above tick labels on the top of the axes for that case.Closes #13735
Before
After
PR Checklist