Repository navigation
Conversation
timhoffm
reviewed
Mar 23, 2019
| if 'rc' not in item['tag_name'] and 'b' not in item['tag_name']: | ||
| dates.append(item['published_at'].split("T")[0]) | ||
| names.append(item['tag_name']) | ||
| except: |
Member
There was a problem hiding this comment.
Suggested change
| except: | |
| except Exception: |
No bare except (see last paragraph of https://docs.python.org/2/howto/doanddont.html#except). Not that it really matters here, but we shouldn't use bad style.
| use_line_collection=True) | ||
|
|
||
| plt.setp(markerline, mec="k", mfc="w", zorder=3) | ||
| markerline.set_ydata(np.zeros(len(dates))) |
Member
There was a problem hiding this comment.
This is a hack on the original purpose of stem. Not sure I like it, but OTOH, the loop before wasn't good either. At least, this needs explanation.
ImportanceOfBeingErnest
force-pushed
the
doc-timeline-example-update
branch
from
March 23, 2019 23:18
6c1dcb5 to
34c4d4b
Compare
Member
Author
|
@timhoffm Do the new changes reflect the points you raised? The docbuild fails for no apparent (to me) reason. Any idea what the problem is? |
timhoffm
approved these changes
Mar 24, 2019
Member
Member
|
@meeseeksdev backport to v3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 25, 2019
![MeeseeksDev[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
timhoffm
added a commit
that referenced
this pull request
Mar 26, 2019
…719-on-v3.1.x Backport PR #13719 on branch v3.1.x (Doc: Update timeline example)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update timeline example to fetch data from the github API. This will allow the example to update itself once new matplotlib versions are released.
Unlike in its initial proposal in #11403, this is embaced in a
try.. except, such that the doc build will not fail in case no internet connection can be established.Also it now uses a
stem(and is hence useful to showstemusage).PR Checklist