Repository navigation
More use of cbook._check_in_list. - #13532
Merged
Merged
Conversation
dstansby
approved these changes
Feb 27, 2019
jklymak
reviewed
Feb 27, 2019
jklymak
left a comment
jklymak
left a comment
Member
There was a problem hiding this comment.
What’s the value error raised by this change? The ones here seem pretty informative, and I don’t see how that is being preserved here...
Member
|
I had a quick look, and I think the new ones are possibly more informative, because they include the list of acceptable strings (instead of just saying string x is bad) |
Contributor
Author
|
These all generate a standardized error message of the form "'foo' is not a valid value for bar; supported values are 'baz', 'quux'" (that's sort of the point of having this helper). |
timhoffm
approved these changes
Feb 27, 2019
QuLogic
added
the
API: argument checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Missed these in #12232.
PR Checklist