Fix imshow()ing PIL-opened images.#13405
Merged
Merged
Conversation
We actually handle grayscale images just fine, but they need to be transformed into masked arrays like everyone else.
tacaswell
approved these changes
Feb 11, 2019
tacaswell
left a comment
tacaswell
left a comment
Member
There was a problem hiding this comment.
More compatibility with less code!
Contributor
Author
|
I think we should have yearly "only allowed to delete old, useless, bug-causing code chunks" periods... |
Member
|
power-cycled to get the fix from master. |
jklymak
approved these changes
Feb 12, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 12, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 12, 2019
timhoffm
added a commit
that referenced
this pull request
Feb 12, 2019
…405-on-v2.2.x Backport PR #13405 on branch v2.2.x (Fix imshow()ing PIL-opened images.)
dstansby
added a commit
that referenced
this pull request
Feb 12, 2019
…405-on-v3.0.x Backport PR #13405 on branch v3.0.x (Fix imshow()ing PIL-opened images.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We actually handle grayscale images just fine, but they need to be
transformed into masked arrays like everyone else.
Closes #12140 (regression in 2.1.0), so maybe worth backporting to 2.2.x.
PR Summary
PR Checklist