Revert "Add inaxes method to FigureCanvas to check whether point is in an axes."#13404
Closed
jklymak wants to merge 1 commit into
Closed
Revert "Add inaxes method to FigureCanvas to check whether point is in an axes."#13404jklymak wants to merge 1 commit into
jklymak wants to merge 1 commit into
Conversation
jklymak
added
the
Release critical
Member
Author
|
Huh, that didn't fully fix it either There was another PR that maybe caused this, or maybe something is wrong w/. CI |
Contributor
|
@jklymak have to tried to test it locally? I do not get any qt error as in travis on master. However, I had to change windows manager else test_dpi_ratio_change would fail. |
Member
|
This looks like a qt configuration error on travis to me... |
Member
Author
|
Yep agreed. Thanks. This pr still needs modificTion but not to be reverted. It was worth a try... |
tacaswell
removed
the
Release critical
Contributor
|
Adding |
This was referenced Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9845 This broke the build, and needs to be re-facotered to work with 3.0.1