FIX: remove idle_event#13403
Merged
Merged
Conversation
jklymak
added
the
Release critical
Contributor
|
This still valid PR @jklymak ? |
Member
Author
|
@lkjell Yes, we need to do this because we removed |
lkjell
approved these changes
Feb 11, 2019
tacaswell
approved these changes
Feb 11, 2019
Contributor
|
CI still broken with qt, but this is a first step... |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
OK, so I screwed up merging #9845 because it called a deprecated method. I guess we ned to make sure PRs run on modern tests if they are so old. My apologies.
Anyways, this PR removes the deprecated method.
NOTE: this unbreaks CI...
PR Checklist