Skip to content

Bump to flake8 3.7.#13337

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:flake837
Feb 1, 2019
Merged

Bump to flake8 3.7.#13337
tacaswell merged 1 commit into
matplotlib:masterfrom
anntzer:flake837

Conversation

@anntzer

@anntzer anntzer commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

flake8 3.7 seems to be working fine now.

The associated bump to pycodestyle 2.5 caught a few more style nits.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The associated bump to pycodestyle 2.5 caught a few more style nits.
@dopplershift

Copy link
Copy Markdown
Contributor

Is there any reason that this change should be affecting what tests we're running? Codecov.io is showing a lot of changes, and it doesn't look spurious.

@tacaswell

Copy link
Copy Markdown
Member

It looks like appveyor did not fire, maybe this is the coverage we get only from appveyor?

Comment thread lib/matplotlib/pyplot.py
@tacaswell tacaswell added this to the v3.1 milestone Feb 1, 2019
@timhoffm

timhoffm commented Feb 1, 2019

Copy link
Copy Markdown
Member

Might be that we need to take care of flake8 also in the other branches (e.g. it's failing in this backport #13340).

@tacaswell tacaswell merged commit 68e8d95 into matplotlib:master Feb 1, 2019
@anntzer anntzer deleted the flake837 branch February 1, 2019 14:38
@tacaswell

Copy link
Copy Markdown
Member

@meeseeksbot backport to v3.0.x

@QuLogic

QuLogic commented Feb 12, 2019

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.0.x

@lumberbot-app

lumberbot-app Bot commented Feb 12, 2019

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 68e8d9543abce31da04a79970fdfb5dea914a540
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #13337: Bump to flake8 3.7.'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-13337-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR #13337 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@QuLogic

QuLogic commented Feb 12, 2019

Copy link
Copy Markdown
Member

OK, I'll put it in #13418.

@tacaswell

Copy link
Copy Markdown
Member

Thanks @QuLogic !

@QuLogic QuLogic modified the milestones: v3.1.0, v3.0.3 Feb 12, 2019
QuLogic added a commit that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants