Defer checking of tex install to when it is actually used.#13285
Merged
Conversation
The call to checkdep_usetex() in `__init__.py` doesn't help for people explicitly passing usetex=True. Moreover, it slows down import time for those who *do* have text.usetex set to True in their rcfile by ~20ms (when timing this, note that checkdep_ghostscript (which checkdep_usetex calls) has a cache, which should be disabled for timing purposes. Moreover, checkdep_usetex is overly broad, always requiring dvipng (which is not required for pdf/ps output) and ghostscript (which is not required for raster output). Instead, move the check to texmanager.py, which will provide a more meaningful error message to end users, speed up import time (20ms is similar to the import time of pyparsing or urllib.request, for example) and avoid the inaccuracies above.
tacaswell
approved these changes
Jan 25, 2019
6 tasks
timhoffm
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to checkdep_usetex() in
__init__.pydoesn't help for peopleexplicitly passing usetex=True. Moreover, it slows down import time
for those who do have text.usetex set to True in their rcfile by ~20ms
(when timing this, note that checkdep_ghostscript (which checkdep_usetex
calls) has a cache, which should be disabled for timing purposes.
Moreover, checkdep_usetex is overly broad, always requiring dvipng
(which is not required for pdf/ps output) and ghostscript (which is not
required for raster output).
Instead, move the check to texmanager.py, which will provide a more
meaningful error message to end users, speed up import time (20ms is
similar to the import time of pyparsing or urllib.request, for example)
and avoid the inaccuracies above.
xref #13284 (if the OP indeed is missing a tex installation).
PR Summary
PR Checklist