Skip to content

DOC Better description of inset locator and colorbar #13272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dstansby merged 3 commits into from
Jan 24, 2019
Merged

DOC Better description of inset locator and colorbar #13272

dstansby merged 3 commits into from
Jan 24, 2019
+15 −8

Conversation

@NelleV
Copy link
Member

@NelleV NelleV commented Jan 24, 2019

PR Summary

This provides a better title and description of the example, as well as uses fig.colorbar instead of plt.colorbar.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jni
jni approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @NelleV for fixing this so quickly after I pointed it out!

@NelleV
Copy link
Member Author

NelleV commented Jan 24, 2019

My pleasure!

QuLogic
QuLogic reviewed Jan 24, 2019
View reviewed changes
QuLogic and others added 2 commits January 24, 2019 18:39
@NelleV
Copy link
Member Author

NelleV commented Jan 24, 2019

@timhoffm agreed. I changed it.

Can whoever merge squash this when merging? I am happy to squash manually as well

dstansby
dstansby approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@dstansby dstansby added this to the v3.0.2-doc milestone Jan 24, 2019
@dstansby dstansby merged commit bf464c3 into matplotlib:master Jan 24, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 24, 2019
@NelleV
Backport PR matplotlib#13272: DOC Better description of inset locator…
a370617 
… and colorbar
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 24, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 24, 2019
@NelleV
Backport PR matplotlib#13272: DOC Better description of inset locator…
5508ea1 
… and colorbar
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 24, 2019
Merged
dstansby pushed a commit that referenced this pull request Jan 24, 2019
@meeseeksmachine @dstansby
Backport PR #13272: DOC Better description of inset locator and color…
d730751 
…bar (#13273)
@NelleV
Copy link
Member Author

NelleV commented Jan 24, 2019

Thanks @dstansby !

@NelleV NelleV deleted the example_fix_demo_colorbar branch January 24, 2019 12:43
tacaswell added a commit that referenced this pull request Jan 27, 2019
@tacaswell
Merge pull request #13274 from meeseeksmachine/auto-backport-of-pr-13…
2e07f24 
…272-on-v3.0.2-doc

Backport PR #13272 on branch v3.0.2-doc (DOC Better description of inset locator and colorbar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic left review comments

@timhoffm timhoffm timhoffm left review comments

@dstansby dstansby dstansby approved these changes

+1 more reviewer

@jni jni jni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.0-doc

Development

Successfully merging this pull request may close these issues.

5 participants

@NelleV @QuLogic @jni @timhoffm @dstansby