Move _windowing extension into _tkagg.#13074
Merged
Merged
Conversation
6 tasks
anntzer
force-pushed
the
windowing-tkagg
branch
from
0ee797d to
0d33556
Compare
QuLogic
reviewed
Jan 3, 2019
anntzer
force-pushed
the
windowing-tkagg
branch
from
0d33556 to
c0e7a9b
Compare
The main point is to remove one not particularly useful customization point from setup.cfg, and the associated logic in setupext.py. Minor additional changes in _tkagg.cpp: use METH_VARARGS instead of the opaque "1" (one can check in Python.h that the values indeed match), and just use `#ifdef _WIN32` to check for Windows-ness (`src/file_compat.h` also uses that check so it works).
anntzer
force-pushed
the
windowing-tkagg
branch
from
c0e7a9b to
824c2ef
Compare
timhoffm
approved these changes
Jan 6, 2019
QuLogic
approved these changes
Jan 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main point is to remove one not particularly useful customization
point from setup.cfg, and the associated logic in setupext.py.
Minor additional changes in _tkagg.cpp: use METH_VARARGS instead of the
opaque "1" (one can check in Python.h that the values indeed match),
and just use
#ifdef _WIN32to check for Windows-ness(
src/file_compat.halso uses that check so it works).PR Summary
PR Checklist