Repository navigation
Canonicalize weights extracted for AFM fonts. - #12991
Conversation
anntzer
added
Release critical
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
Is there any way to add a test for this? (no worries if there isn't an easy way)
|
test added |
7443388 to
ba14866
Compare
|
|
||
| weight = font.get_weight().lower() | ||
| if weight not in weight_dict: | ||
| weight = 'normal' |
There was a problem hiding this comment.
Should the fallback issue some warning or log?
There was a problem hiding this comment.
Well, previously it didn't (although the fallback occurred in score_weight, but the idea is the same), and it's not as if the end user can do anything about that.
(To be fully honest it's not clear to me why we even bother trying to get font properties from AFM files as these only contain metrics but not outlines, so to visualize the pdf you'll need to have the actual font file (typically, .pfa/.pfb) as well; the only exception is for the "14 pdf core fonts" (helvetica, etc.) which must be embedded in each pdf viewer (and there we do still need the metrics to know the size of the glyphs for alignment purposes) but even then we could just hardcode that info in parsed form instead of reparsing them from matplotlib/mpl-data/fonts/pdfcorefonts/ every time...)
ba14866 to
7492570
Compare
PR Summary
Fixes the part of #12987 that I broke...
PR Checklist