Fixed to contour to support the _as_mpl_transform api. #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I would vote to fix the self.transform to self._transform now before release. Once we release it that way, we are largely stuck with it. The choice of API is very important and not to be taken lightly. |
…a get_transform method).
Member
Author
|
Have done. Thanks @WeatherGod. |
mdboom
added a commit
that referenced
this pull request
Sep 21, 2012
Fixed to contour to support the _as_mpl_transform api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out a bug fix PR (#1265) broke my own feature PR (#1090) of having an external
_as_mpl_transformapi.Even if this doesn't make it in the final 1.2 cut (i.e. we don't find any issues with RC2), I think it is worth merging into the 1.2 branch.
Because we are so close to a release, I have tried to minimize any changes, hence have not changed the ContourSet's
transformattribute to be private (i.e._transform).