Skip to content

Fixed to contour to support the _as_mpl_transform api. - #1293

Merged
mdboom merged 2 commits into
matplotlib:v1.2.xfrom
pelson:trans_api_fix
Sep 21, 2012
Merged

mdboom merged 2 commits into
matplotlib:v1.2.xfrom
pelson:trans_api_fix

Conversation

@pelson

@pelson pelson commented Sep 21, 2012

Copy link
Copy Markdown
Member

It turns out a bug fix PR (#1265) broke my own feature PR (#1090) of having an external _as_mpl_transform api.

Even if this doesn't make it in the final 1.2 cut (i.e. we don't find any issues with RC2), I think it is worth merging into the 1.2 branch.

Because we are so close to a release, I have tried to minimize any changes, hence have not changed the ContourSet's transform attribute to be private (i.e. _transform).

@WeatherGod

Copy link
Copy Markdown
Member

I would vote to fix the self.transform to self._transform now before release. Once we release it that way, we are largely stuck with it. The choice of API is very important and not to be taken lightly.

@pelson

pelson commented Sep 21, 2012

Copy link
Copy Markdown
Member Author

Have done. Thanks @WeatherGod.

mdboom added a commit that referenced this pull request Sep 21, 2012
Fixed to contour to support the _as_mpl_transform api.
@mdboom
mdboom merged commit 58a933f into matplotlib:v1.2.x Sep 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants