Fix TypeError when calculating tick_values #12809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
approved these changes
Nov 14, 2018
Member
efiring
left a comment
efiring
left a comment
There was a problem hiding this comment.
How embarrassing! Not only did I get it wrong the first time, but when I went back to look at it just now, I didn't see it until I looked at your patch. Thank you for catching and fixing it.
ImportanceOfBeingErnest
approved these changes
Nov 15, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 15, 2018
This was referenced Nov 15, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 15, 2018
QuLogic
added a commit
that referenced
this pull request
Jan 22, 2019
…809-on-v3.0.x Backport PR #12809 on branch v3.0.x (Fix TypeError when calculating tick_values)
QuLogic
added a commit
that referenced
this pull request
Jan 22, 2019
…809-on-v2.2.x Backport PR #12809 on branch v2.2.x (Fix TypeError when calculating tick_values)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #12806.
This was caused by a misplaced parentheses. Introduced in 54d6f08 (attn. @efiring).