Repository navigation
Make colorbars constructible with dataless ScalarMappables. - #12767
Merged
Merged
Conversation
This allows creating "bare" colorbars with the one-liner
fig.colorbar(cm.ScalarMappable(norm=norm, cmap=cmap))
anntzer
force-pushed
the
scalarmappable-default-array
branch
from
November 7, 2018 21:00
4ed0703 to
961742c
Compare
Member
|
I think I remember that just doing This is pretty useful, because it makes manual colorbar creation much more intuitive. |
ImportanceOfBeingErnest
approved these changes
Nov 8, 2018
jklymak
approved these changes
Nov 8, 2018
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows creating "bare" colorbars with the one-liner
xref #3644 (comment)
As to the answer to the question in that comment ("What would be the implication if that is changed to self._A = []?"):
That wouldn't work because ScalarMappables need to also support cases where the color is directly set by the end user (explicit RGBA image, or explicit colors in scatter plots), in which case they mark that fact with A == None (at least initially, then A becomes the RGBA array, the whole thing looks a bit messy...).
PR Summary
PR Checklist