Skip to content

Rename tkinter import from Tk to tk. - #12704

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:tk
Nov 4, 2018
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:tk

Conversation

@anntzer

@anntzer anntzer commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

Currently we import tkinter as Tk, which is a bit confusing as there
is also a tkinter.Tk class (for example, both tkinter.mainloop --
currently aliased as Tk.mainloop -- and tkinter.Tk.mainloop exist).
Instead, import tkinter as tk; this shorthand is also consistent with
the tkinter docs (https://docs.python.org/3/library/tkinter.html).

Noted while investigating #12703.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the GUI: tk label Nov 1, 2018
@dstansby dstansby added this to the v3.1 milestone Nov 2, 2018
@tacaswell

Copy link
Copy Markdown
Member

This has conflicts, presumably from #12707

Currently we `import tkinter as Tk`, which is a bit confusing as there
is also a `tkinter.Tk` class (for example, both `tkinter.mainloop` --
currently aliased as `Tk.mainloop` -- and `tkinter.Tk.mainloop` exist).
Instead, `import tkinter as tk`; this shorthand is also consistent with
the tkinter docs (https://docs.python.org/3/library/tkinter.html).
@anntzer

anntzer commented Nov 4, 2018

Copy link
Copy Markdown
Contributor Author

rebased

@timhoffm
timhoffm merged commit bed61ee into matplotlib:master Nov 4, 2018
@anntzer
anntzer deleted the tk branch November 4, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants