STY: fix whitespace and escaping #12607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tacaswell
commented
Oct 24, 2018
tacaswell
commented
- Has Pytest style unit tests
- Code is Flake 8 compliant
- New features are documented, with examples if plot related
- Documentation is sphinx and numpydoc compliant
- Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
- Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Member
Author
|
This fixes up flake8 violations I put in merging 3.0.x up to master. |
QuLogic
approved these changes
Oct 24, 2018
jklymak
approved these changes
Oct 24, 2018
Member
|
This needs to be backported right? Right now 3.0.x if failing flake8 on these errors @meeseeksdev backport to v3.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 24, 2018
jklymak
added a commit
that referenced
this pull request
Oct 24, 2018
…607-on-v3.0.x Backport PR #12607 on branch v3.0.x (STY: fix whitespace and escaping)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.