Skip to content

Avoid quadratic behavior when accumulating stickies. #12546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jklymak merged 1 commit into from
Oct 17, 2018
Merged

Avoid quadratic behavior when accumulating stickies. #12546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/matplotlib/axes/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2405,12 +2405,12 @@ def autoscale_view(self, tight=None, scalex=True, scaley=True):

if self.use_sticky_edges and (self._xmargin or self._ymargin):
stickies = [artist.sticky_edges for artist in self.get_children()]
x_stickies = sum([sticky.x for sticky in stickies], [])
y_stickies = sum([sticky.y for sticky in stickies], [])
x_stickies = np.array([x for sticky in stickies for x in sticky.x])
Copy link
Contributor Author

@anntzer anntzer Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np.isclose is called just below anyways so converting to array here vs just below shouldn't affect performance.

y_stickies = np.array([y for sticky in stickies for y in sticky.y])
if self.get_xscale().lower() == 'log':
x_stickies = [xs for xs in x_stickies if xs > 0]
x_stickies = x_stickies[x_stickies > 0]
if self.get_yscale().lower() == 'log':
y_stickies = [ys for ys in y_stickies if ys > 0]
y_stickies = y_stickies[y_stickies > 0]
else: # Small optimization.
x_stickies, y_stickies = [], []

Expand Down