Repository navigation
Conversation
As described in matplotlib#12121, the current documentation of `textprops` keyword parameter strongly, and erroneously, suggests that `textprops` should be a FontProperties object. In reality, it should instead be a dictionary of keyword parameters that will be passed to the `Text` object inside of `TextArea`. This commit changes the documentation to reflect the current behavior. closes matplotlib#12121
galenlynch
force-pushed
the
clarify_TextArea_fontprops_documentation
branch
from
October 7, 2018 18:39
f0b549c to
2aa52db
Compare
timhoffm
approved these changes
Oct 7, 2018
Contributor
|
thanks! |
Contributor
Author
|
My pleasure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #12121, the current documentation of
textpropskeywordparameter strongly, and erroneously, suggests that
textpropsshould be aFontProperties object. In reality, it should instead be a dictionary of keyword
parameters that will be passed to the
Textobject inside ofTextArea. Thiscommit changes the documentation to reflect the current behavior.
closes #12121
PR Summary
PR Checklist