Repository navigation
Improve selection of inset indicator connectors. - #12334
Conversation
Instead of selecting just one pair of corners, determine whether each connector is visible individually based on relative position of the bbox corners that each one connects.
|
This is great. You should include the code for the above as an example somewhere too! I assume this works as well w an oblong shape as well? |
|
Cool stuff. If you look closely there is a little hickup at ~0°. (Image taken from screen capture of the above animation)
I'm not able to reproduce this locally. Is this expected? |
|
Hmm, that is weird, but the way |
|
Oblong shapes seem fine (and should be since this looks at individual corners now): |
|
For the drawing bug have a look at: #11753 |
![MeeseeksDev[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…334-on-v3.0.x Backport PR #12334 on branch v3.0.x (Improve selection of inset indicator connectors.)
PR Summary
Instead of selecting just one pair of corners, determine whether each connector is visible individually based on relative position of the bbox corners that each one connects.
It took me a couple of false starts, but ended up relatively simple in the end.
Fixes #12323.
Since it's marked experimental, I'll leave it to @jklymak to determine milestoning, and then write up the changelog accordingly, and maybe update the test too.
On master
This PR
PR Checklist