Don't try to order the contours of TrueType fonts #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a lot of code that was trying to output the matching outer and inner contours in some specific order, but mistakenly combined two contours in the percent glyph in the Bitstream Vera Sans font.
mdboom
added a commit
that referenced
this pull request
Sep 10, 2012
Don't try to order the contours of TrueType fonts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of code that was trying to output the matching
outer and inner contours in some specific order, but mistakenly
combined two contours in the percent glyph in the Bitstream Vera Sans
font (issue #1211).
I don't consider this ready for merging, but the change does appear to fix #1211 for me, and in some brief testing I didn't see it break the rendering of anything else in pdf or ps output. It could use wider testing in other people's setups, especially on a variety of different ttf fonts.
I don't really understand why the code I removed was there to begin with. I think it was @mdboom who added the ttconv code initially, so he might know more about it?